Bug: Index Editor affects line-endings

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bug: Index Editor affects line-endings

SmartGit mailing list
I encountered a (probably rare) bug in the index editor.

 What I did/how to reproduce:
 1. have a tracked file with unix line endings (with some commits already)
 2. then I (unintentionally) inserted some (not all!) lines with windows endings and committed (no error here, git can deal perfectly with mixed endings - a warning from smartgit would be nice.)
 3. edit the file again in at least two places
 4. stage the file
 5. use index editor to revert one of the two changed places and save
 6. commit

 

 The result is that the index editor changed ALL line endings to windows (without any notice, warning, etc.). this causes a small, local mistake (in step 2) to affect the whole file.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug: Index Editor affects line-endings

SmartGit mailing list
>  1. have a tracked file with unix line endings (with some commits already)
>  2. then I (unintentionally) inserted some (not all!) lines with windows endings
> and committed (no error here, git can deal perfectly with mixed endings - a
> warning from smartgit would be nice.)

How did you manage to do that?

--
Best regards,
Thomas Singer
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


01/28/2015 10:50 - [hidden email] [smartgit] wrote:

> I encountered a (probably rare) bug in the index editor.
>
>  What I did/how to reproduce:
>  1. have a tracked file with unix line endings (with some commits already)
>  2. then I (unintentionally) inserted some (not all!) lines with windows endings
> and committed (no error here, git can deal perfectly with mixed endings - a
> warning from smartgit would be nice.)
>  3. edit the file again in at least two places
>  4. stage the file
>  5. use index editor to revert one of the two changed places and save
>  6. commit
>
>  
>
>  The result is that the index editor changed ALL line endings to windows (without
> any notice, warning, etc.). this causes a small, local mistake (in step 2) to
> affect the whole file.
>
>
Loading...