Patchset review feature?

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Patchset review feature?

Norbert Nemec
Hi there,

a very common use case for me is reviewing of patchsets that I have
already committed. For that, I need a complete diff-view between an
older commit and the current working tree, allowing to open individual
files in an external diff program that allows direct editing of the file
in the working tree.

Is this possible in some way that I have missed?

If not, the most straightforward solution would be the option to choose
a base commit other than HEAD in the regular Review mode.

Any ideas about that?

Greetings,
Norbert


--
Dr. Norbert Nemec
Software Development

Tel +49-30-611035-1882
[hidden email]

KOMPLETE 8 ULTIMATE - the premium NI producer collection
=>  http://www.native-instruments.com/komplete8

TRAKTOR KONTROL S2 - the professional 2.1 DJ system
=>  http://www.native-instruments.com/s2

->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-

Registergericht: Amtsgericht Charlottenburg
Registernummer: HRB 72458
UST.-ID.-Nr. DE 20 374 7747

Geschäftsführung: Daniel Haver (CEO), Mate Galic


------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/smartgit/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/smartgit/join
    (Yahoo! ID required)

<*> To change settings via email:
    [hidden email]
    [hidden email]

<*> To unsubscribe from this group, send an email to:
    [hidden email]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

syntevo Support
Hi Norbert,

Did you already try to select two commits in the Log?

--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


10/19/2011 11:20 - Norbert Nemec wrote:

> Hi there,
>
> a very common use case for me is reviewing of patchsets that I have
> already committed. For that, I need a complete diff-view between an
> older commit and the current working tree, allowing to open individual
> files in an external diff program that allows direct editing of the file
> in the working tree.
>
> Is this possible in some way that I have missed?
>
> If not, the most straightforward solution would be the option to choose
> a base commit other than HEAD in the regular Review mode.
>
> Any ideas about that?
>
> Greetings,
> Norbert
>
>
> --
> Dr. Norbert Nemec
> Software Development
>
> Tel +49-30-611035-1882
> [hidden email]
>
> KOMPLETE 8 ULTIMATE - the premium NI producer collection
> =>  http://www.native-instruments.com/komplete8
>
> TRAKTOR KONTROL S2 - the professional 2.1 DJ system
> =>  http://www.native-instruments.com/s2
>
> ->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-
>
> Registergericht: Amtsgericht Charlottenburg
> Registernummer: HRB 72458
> UST.-ID.-Nr. DE 20 374 7747
>
> Geschäftsführung: Daniel Haver (CEO), Mate Galic
>
>
> ------------------------------------
>
> Yahoo! Groups Links
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

Norbert Nemec
Indeed, I tried various things in the Log but missed this one. My first
intuitive attempt was to select a range but this did not work, so I gave
up trying in that direction.

Anyway: the log-view is not quite good enough, because it does not allow
access to the working tree and it does not allow editing the working
tree within the diff view.

BTW: editing in the diff-view generally is an essential feature missing
in SmartGIT. It would be extremely useful in the commit review window.

Greetings,
Norbert


Am 19.10.11 11:44, schrieb syntevo Support:

> Hi Norbert,
>
> Did you already try to select two commits in the Log?
>
> --
> Best regards,
> Thomas Singer
> =============
> syntevo GmbH
> http://www.syntevo.com
> http://blog.syntevo.com
>
> 10/19/2011 11:20 - Norbert Nemec wrote:
>
>  > Hi there,
>  >
>  > a very common use case for me is reviewing of patchsets that I have
>  > already committed. For that, I need a complete diff-view between an
>  > older commit and the current working tree, allowing to open individual
>  > files in an external diff program that allows direct editing of the file
>  > in the working tree.
>  >
>  > Is this possible in some way that I have missed?
>  >
>  > If not, the most straightforward solution would be the option to choose
>  > a base commit other than HEAD in the regular Review mode.
>  >
>  > Any ideas about that?
>  >
>  > Greetings,
>  > Norbert
>  >
>  >
>  > --
>  > Dr. Norbert Nemec
>  > Software Development
>  >
>  > Tel +49-30-611035-1882
>  > [hidden email]
> <mailto:norbert.nemec%40native-instruments.de>
>  >
>  > KOMPLETE 8 ULTIMATE - the premium NI producer collection
>  > => http://www.native-instruments.com/komplete8
>  >
>  > TRAKTOR KONTROL S2 - the professional 2.1 DJ system
>  > => http://www.native-instruments.com/s2
>  >
>  > ->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-
>  >
>  > Registergericht: Amtsgericht Charlottenburg
>  > Registernummer: HRB 72458
>  > UST.-ID.-Nr. DE 20 374 7747
>  >
>  > Geschäftsführung: Daniel Haver (CEO), Mate Galic
>  >
>  >
>  > ------------------------------------
>  >
>  > Yahoo! Groups Links
>  >
>  >
>  >
>  >
>
>

--
Dr. Norbert Nemec
Software Development

Tel +49-30-611035-1882
[hidden email]

KOMPLETE 8 ULTIMATE - the premium NI producer collection
=>  http://www.native-instruments.com/komplete8

TRAKTOR KONTROL S2 - the professional 2.1 DJ system
=>  http://www.native-instruments.com/s2

->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-

Registergericht: Amtsgericht Charlottenburg
Registernummer: HRB 72458
UST.-ID.-Nr. DE 20 374 7747

Geschäftsführung: Daniel Haver (CEO), Mate Galic
Reply | Threaded
Open this post in threaded view
|

RE: Patchset review feature?

Tom Deblauwe
I totally agree and I am having this problem a lot.

The use case is always when doing code reviews that you need to show your fellow developers what has changed + you need to edit the working tree to change the code or add some comments from the other developers.
Now I have to right-click, select “compare with working tree”, and then choose to compare the old file content and then click again on “compare”. And I have to do this for every file so the suggestion of Norbert would solve this issue.

Best regards,
Tom,

From: [hidden email] [mailto:[hidden email]] On Behalf Of Norbert Nemec
Sent: woensdag 19 oktober 2011 13:38
To: [hidden email]
Subject: Re: [smartgit] Patchset review feature?



Indeed, I tried various things in the Log but missed this one. My first
intuitive attempt was to select a range but this did not work, so I gave
up trying in that direction.

Anyway: the log-view is not quite good enough, because it does not allow
access to the working tree and it does not allow editing the working
tree within the diff view.

BTW: editing in the diff-view generally is an essential feature missing
in SmartGIT. It would be extremely useful in the commit review window.

Greetings,
Norbert

Am 19.10.11 11:44, schrieb syntevo Support:

> Hi Norbert,
>
> Did you already try to select two commits in the Log?
>
> --
> Best regards,
> Thomas Singer
> =============
> syntevo GmbH
> http://www.syntevo.com
> http://blog.syntevo.com
>
> 10/19/2011 11:20 - Norbert Nemec wrote:
>
> > Hi there,
> >
> > a very common use case for me is reviewing of patchsets that I have
> > already committed. For that, I need a complete diff-view between an
> > older commit and the current working tree, allowing to open individual
> > files in an external diff program that allows direct editing of the file
> > in the working tree.
> >
> > Is this possible in some way that I have missed?
> >
> > If not, the most straightforward solution would be the option to choose
> > a base commit other than HEAD in the regular Review mode.
> >
> > Any ideas about that?
> >
> > Greetings,
> > Norbert
> >
> >
> > --
> > Dr. Norbert Nemec
> > Software Development
> >
> > Tel +49-30-611035-1882
> > [hidden email]<mailto:norbert.nemec%40native-instruments.de>
> <mailto:norbert.nemec%40native-instruments.de>
> >
> > KOMPLETE 8 ULTIMATE - the premium NI producer collection
> > => http://www.native-instruments.com/komplete8
> >
> > TRAKTOR KONTROL S2 - the professional 2.1 DJ system
> > => http://www.native-instruments.com/s2
> >
> > ->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-
> >
> > Registergericht: Amtsgericht Charlottenburg
> > Registernummer: HRB 72458
> > UST.-ID.-Nr. DE 20 374 7747
> >
> > Geschäftsführung: Daniel Haver (CEO), Mate Galic
> >
> >
> > ------------------------------------
> >
> > Yahoo! Groups Links
> >
> >
> >
> >
>
>

--
Dr. Norbert Nemec
Software Development

Tel +49-30-611035-1882
[hidden email]<mailto:norbert.nemec%40native-instruments.de>

KOMPLETE 8 ULTIMATE - the premium NI producer collection
=> http://www.native-instruments.com/komplete8

TRAKTOR KONTROL S2 - the professional 2.1 DJ system
=> http://www.native-instruments.com/s2

->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-

Registergericht: Amtsgericht Charlottenburg
Registernummer: HRB 72458
UST.-ID.-Nr. DE 20 374 7747

Geschäftsführung: Daniel Haver (CEO), Mate Galic



[Non-text portions of this message have been removed]

Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

syntevo Support
In reply to this post by Norbert Nemec
> BTW: editing in the diff-view generally is an essential feature missing
> in SmartGIT.

Of course, SmartGit offers editing in the compare window - as long as you compare with the working tree (either from the project window or by using Query -> Compare With Working Tree from the log window).

Could you please describe your use case in more details: Where are the commits located which you are reviewing (same branch, other branch)? Do you integrate commits from other developers? Should your changes go into separate commits or should they modify the other ones?

--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


10/19/2011 13:40 - Norbert Nemec wrote:

> Indeed, I tried various things in the Log but missed this one. My first
> intuitive attempt was to select a range but this did not work, so I gave
> up trying in that direction.
>
> Anyway: the log-view is not quite good enough, because it does not allow
> access to the working tree and it does not allow editing the working
> tree within the diff view.
>
> BTW: editing in the diff-view generally is an essential feature missing
> in SmartGIT. It would be extremely useful in the commit review window.
>
> Greetings,
> Norbert
>
>
> Am 19.10.11 11:44, schrieb syntevo Support:
> > Hi Norbert,
> >
> > Did you already try to select two commits in the Log?
> >
> > --
> > Best regards,
> > Thomas Singer
> > =============
> > syntevo GmbH
> > http://www.syntevo.com
> > http://blog.syntevo.com
> >
> > 10/19/2011 11:20 - Norbert Nemec wrote:
> >
> >  > Hi there,
> >  >
> >  > a very common use case for me is reviewing of patchsets that I have
> >  > already committed. For that, I need a complete diff-view between an
> >  > older commit and the current working tree, allowing to open individual
> >  > files in an external diff program that allows direct editing of the file
> >  > in the working tree.
> >  >
> >  > Is this possible in some way that I have missed?
> >  >
> >  > If not, the most straightforward solution would be the option to choose
> >  > a base commit other than HEAD in the regular Review mode.
> >  >
> >  > Any ideas about that?
> >  >
> >  > Greetings,
> >  > Norbert
> >  >
> >  >
> >  > --
> >  > Dr. Norbert Nemec
> >  > Software Development
> >  >
> >  > Tel +49-30-611035-1882
> >  > [hidden email]
> > <mailto:norbert.nemec%40native-instruments.de>
> >  >
> >  > KOMPLETE 8 ULTIMATE - the premium NI producer collection
> >  > => http://www.native-instruments.com/komplete8
> >  >
> >  > TRAKTOR KONTROL S2 - the professional 2.1 DJ system
> >  > => http://www.native-instruments.com/s2
> >  >
> >  > ->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-
> >  >
> >  > Registergericht: Amtsgericht Charlottenburg
> >  > Registernummer: HRB 72458
> >  > UST.-ID.-Nr. DE 20 374 7747
> >  >
> >  > Geschäftsführung: Daniel Haver (CEO), Mate Galic
> >  >
> >  >
> >  > ------------------------------------
> >  >
> >  > Yahoo! Groups Links
> >  >
> >  >
> >  >
> >  >
> >
> >
>
> --
> Dr. Norbert Nemec
> Software Development
>
> Tel +49-30-611035-1882
> [hidden email]
>
> KOMPLETE 8 ULTIMATE - the premium NI producer collection
> =>  http://www.native-instruments.com/komplete8
>
> TRAKTOR KONTROL S2 - the professional 2.1 DJ system
> =>  http://www.native-instruments.com/s2
>
> ->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-
>
> Registergericht: Amtsgericht Charlottenburg
> Registernummer: HRB 72458
> UST.-ID.-Nr. DE 20 374 7747
>
> Geschäftsführung: Daniel Haver (CEO), Mate Galic
>
Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

Norbert Nemec


Am 19.10.11 14:10, schrieb syntevo Support:
>  > BTW: editing in the diff-view generally is an essential feature missing
>  > in SmartGIT.
>
> Of course, SmartGit offers editing in the compare window - as long as
> you compare with the working tree (either from the project window or by
> using Query -> Compare With Working Tree from the log window).

Thanks! Now I found the editing feature in the project window: Nearly at
the point where I had been looking. Only that I did not consider
clicking on the "Changes" button. Why isn't the diff editable right in
the diff view at the bottom of the review window? Typically, this is the
place where I view the changes. When I find an issue I need to edit, I
should be able to do it right there rather than having to open the
"Changes" window and find the same spot in the file again to make the edit.

The other place, "Query -> Compare With Working Tree" actually allows
the kind of editing that I need. Compare with an older version while
editing the working tree file. Somehow I missed that menu entry. Still
it is somewhat awkward to go through the menu and the dialog for each file.

Perhaps, the log view could simply show the uncommitted working tree at
the very top, so one could directly make a diff between it and a
historic version. With that feature, editing could again be allowed
right in the regular diff view.


> Could you please describe your use case in more details: Where are the
> commits located which you are reviewing (same branch, other branch)? Do
> you integrate commits from other developers? Should your changes go into
> separate commits or should they modify the other ones?

I want to review a bunch of commits at the top of my active branch and
edit the working tree right in place wherever I find an issue. The
changes should simply remain in the working tree to be committed (or
amended) in a separate step, possibly later after I have cleaned up and
tested them.

>
> --
> Best regards,
> Thomas Singer
> =============
> syntevo GmbH
> http://www.syntevo.com
> http://blog.syntevo.com
>
> 10/19/2011 13:40 - Norbert Nemec wrote:
>
>  > Indeed, I tried various things in the Log but missed this one. My first
>  > intuitive attempt was to select a range but this did not work, so I gave
>  > up trying in that direction.
>  >
>  > Anyway: the log-view is not quite good enough, because it does not allow
>  > access to the working tree and it does not allow editing the working
>  > tree within the diff view.
>  >
>  > BTW: editing in the diff-view generally is an essential feature missing
>  > in SmartGIT. It would be extremely useful in the commit review window.
>  >
>  > Greetings,
>  > Norbert
>  >
>  >
>  > Am 19.10.11 11:44, schrieb syntevo Support:
>  > > Hi Norbert,
>  > >
>  > > Did you already try to select two commits in the Log?
>  > >
>  > > --
>  > > Best regards,
>  > > Thomas Singer
>  > > =============
>  > > syntevo GmbH
>  > > http://www.syntevo.com
>  > > http://blog.syntevo.com
>  > >
>  > > 10/19/2011 11:20 - Norbert Nemec wrote:
>  > >
>  > > > Hi there,
>  > > >
>  > > > a very common use case for me is reviewing of patchsets that I have
>  > > > already committed. For that, I need a complete diff-view between an
>  > > > older commit and the current working tree, allowing to open
> individual
>  > > > files in an external diff program that allows direct editing of
> the file
>  > > > in the working tree.
>  > > >
>  > > > Is this possible in some way that I have missed?
>  > > >
>  > > > If not, the most straightforward solution would be the option to
> choose
>  > > > a base commit other than HEAD in the regular Review mode.
>  > > >
>  > > > Any ideas about that?
>  > > >
>  > > > Greetings,
>  > > > Norbert
>  > > >
>  > > >
>  > > > --
>  > > > Dr. Norbert Nemec
>  > > > Software Development
>  > > >
>  > > > Tel +49-30-611035-1882
>  > > > [hidden email]
> <mailto:norbert.nemec%40native-instruments.de>
>  > > <mailto:norbert.nemec%40native-instruments.de>
>  > > >
>  > > > KOMPLETE 8 ULTIMATE - the premium NI producer collection
>  > > > => http://www.native-instruments.com/komplete8
>  > > >
>  > > > TRAKTOR KONTROL S2 - the professional 2.1 DJ system
>  > > > => http://www.native-instruments.com/s2
>  > > >
>  > > > ->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-
>  > > >
>  > > > Registergericht: Amtsgericht Charlottenburg
>  > > > Registernummer: HRB 72458
>  > > > UST.-ID.-Nr. DE 20 374 7747
>  > > >
>  > > > Geschäftsführung: Daniel Haver (CEO), Mate Galic
>  > > >
>  > > >
>  > > > ------------------------------------
>  > > >
>  > > > Yahoo! Groups Links
>  > > >
>  > > >
>  > > >
>  > > >
>  > >
>  > >
>  >
>  > --
>  > Dr. Norbert Nemec
>  > Software Development
>  >
>  > Tel +49-30-611035-1882
>  > [hidden email]
> <mailto:norbert.nemec%40native-instruments.de>
>  >
>  > KOMPLETE 8 ULTIMATE - the premium NI producer collection
>  > => http://www.native-instruments.com/komplete8
>  >
>  > TRAKTOR KONTROL S2 - the professional 2.1 DJ system
>  > => http://www.native-instruments.com/s2
>  >
>  > ->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-
>  >
>  > Registergericht: Amtsgericht Charlottenburg
>  > Registernummer: HRB 72458
>  > UST.-ID.-Nr. DE 20 374 7747
>  >
>  > Geschäftsführung: Daniel Haver (CEO), Mate Galic
>  >
>
>

--
Dr. Norbert Nemec
Software Development

Tel +49-30-611035-1882
[hidden email]

KOMPLETE 8 ULTIMATE - the premium NI producer collection
=>  http://www.native-instruments.com/komplete8

TRAKTOR KONTROL S2 - the professional 2.1 DJ system
=>  http://www.native-instruments.com/s2

->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-

Registergericht: Amtsgericht Charlottenburg
Registernummer: HRB 72458
UST.-ID.-Nr. DE 20 374 7747

Geschäftsführung: Daniel Haver (CEO), Mate Galic
Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

Norbert Nemec
In reply to this post by Tom Deblauwe
Am 19.10.11 13:55, schrieb Tom Deblauwe:
> I totally agree and I am having this problem a lot.
>
> The use case is always when doing code reviews that you need to show
> your fellow developers what has changed + you need to edit the working
> tree to change the code or add some comments from the other developers.

Exactly that. I have finished my work and produced a number of commits.
Now I sit in front of my machine with a collegue, explaining the details
and getting feedback that I want to note down or even quickly implement
right there in-place.

So far, I have been using an awkward combination of various tools to
allow this. SmartGIT nearly allows my to have everything comfortable in
one place.



--
Dr. Norbert Nemec
Software Development

Tel +49-30-611035-1882
[hidden email]

KOMPLETE 8 ULTIMATE - the premium NI producer collection
=>  http://www.native-instruments.com/komplete8

TRAKTOR KONTROL S2 - the professional 2.1 DJ system
=>  http://www.native-instruments.com/s2

->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-

Registergericht: Amtsgericht Charlottenburg
Registernummer: HRB 72458
UST.-ID.-Nr. DE 20 374 7747

Geschäftsführung: Daniel Haver (CEO), Mate Galic
Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

syntevo Support
In reply to this post by Norbert Nemec
> Why isn't the diff editable right in
> the diff view at the bottom of the review window? Typically, this is the
> place where I view the changes. When I find an issue I need to edit, I
> should be able to do it right there rather than having to open the
> "Changes" window and find the same spot in the file again to make the edit.

The Changes view will be updated automatically when the user selects a
different file or when the file system refreshs. If we would make it
editable, then the question would be what to do if the user changes
selection? Should selection changes be prevented?

--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


On 19.10.2011 14:39, Norbert Nemec wrote:

>
>
> Am 19.10.11 14:10, schrieb syntevo Support:
>>   >  BTW: editing in the diff-view generally is an essential feature missing
>>   >  in SmartGIT.
>>
>> Of course, SmartGit offers editing in the compare window - as long as
>> you compare with the working tree (either from the project window or by
>> using Query ->  Compare With Working Tree from the log window).
>
> Thanks! Now I found the editing feature in the project window: Nearly at
> the point where I had been looking. Only that I did not consider
> clicking on the "Changes" button. Why isn't the diff editable right in
> the diff view at the bottom of the review window? Typically, this is the
> place where I view the changes. When I find an issue I need to edit, I
> should be able to do it right there rather than having to open the
> "Changes" window and find the same spot in the file again to make the edit.
>
> The other place, "Query ->  Compare With Working Tree" actually allows
> the kind of editing that I need. Compare with an older version while
> editing the working tree file. Somehow I missed that menu entry. Still
> it is somewhat awkward to go through the menu and the dialog for each file.
>
> Perhaps, the log view could simply show the uncommitted working tree at
> the very top, so one could directly make a diff between it and a
> historic version. With that feature, editing could again be allowed
> right in the regular diff view.
>
>
>> Could you please describe your use case in more details: Where are the
>> commits located which you are reviewing (same branch, other branch)? Do
>> you integrate commits from other developers? Should your changes go into
>> separate commits or should they modify the other ones?
>
> I want to review a bunch of commits at the top of my active branch and
> edit the working tree right in place wherever I find an issue. The
> changes should simply remain in the working tree to be committed (or
> amended) in a separate step, possibly later after I have cleaned up and
> tested them.
>
>>
>> --
>> Best regards,
>> Thomas Singer
>> =============
>> syntevo GmbH
>> http://www.syntevo.com
>> http://blog.syntevo.com
>>
>> 10/19/2011 13:40 - Norbert Nemec wrote:
>>
>>   >  Indeed, I tried various things in the Log but missed this one. My first
>>   >  intuitive attempt was to select a range but this did not work, so I gave
>>   >  up trying in that direction.
>>   >
>>   >  Anyway: the log-view is not quite good enough, because it does not allow
>>   >  access to the working tree and it does not allow editing the working
>>   >  tree within the diff view.
>>   >
>>   >  BTW: editing in the diff-view generally is an essential feature missing
>>   >  in SmartGIT. It would be extremely useful in the commit review window.
>>   >
>>   >  Greetings,
>>   >  Norbert
>>   >
>>   >
>>   >  Am 19.10.11 11:44, schrieb syntevo Support:
>>   >  >  Hi Norbert,
>>   >  >
>>   >  >  Did you already try to select two commits in the Log?
>>   >  >
>>   >  >  --
>>   >  >  Best regards,
>>   >  >  Thomas Singer
>>   >  >  =============
>>   >  >  syntevo GmbH
>>   >  >  http://www.syntevo.com
>>   >  >  http://blog.syntevo.com
>>   >  >
>>   >  >  10/19/2011 11:20 - Norbert Nemec wrote:
>>   >  >
>>   >  >  >  Hi there,
>>   >  >  >
>>   >  >  >  a very common use case for me is reviewing of patchsets that I have
>>   >  >  >  already committed. For that, I need a complete diff-view between an
>>   >  >  >  older commit and the current working tree, allowing to open
>> individual
>>   >  >  >  files in an external diff program that allows direct editing of
>> the file
>>   >  >  >  in the working tree.
>>   >  >  >
>>   >  >  >  Is this possible in some way that I have missed?
>>   >  >  >
>>   >  >  >  If not, the most straightforward solution would be the option to
>> choose
>>   >  >  >  a base commit other than HEAD in the regular Review mode.
>>   >  >  >
>>   >  >  >  Any ideas about that?
>>   >  >  >
>>   >  >  >  Greetings,
>>   >  >  >  Norbert
>>   >  >  >
>>   >  >  >
>>   >  >  >  --
>>   >  >  >  Dr. Norbert Nemec
>>   >  >  >  Software Development
>>   >  >  >
>>   >  >  >  Tel +49-30-611035-1882
>>   >  >  >  [hidden email]
>> <mailto:norbert.nemec%40native-instruments.de>
>>   >  >  <mailto:norbert.nemec%40native-instruments.de>
>>   >  >  >
>>   >  >  >  KOMPLETE 8 ULTIMATE - the premium NI producer collection
>>   >  >  >  =>  http://www.native-instruments.com/komplete8
>>   >  >  >
>>   >  >  >  TRAKTOR KONTROL S2 - the professional 2.1 DJ system
>>   >  >  >  =>  http://www.native-instruments.com/s2
>>   >  >  >
>>   >  >  >  ->>>>>>  NATIVE INSTRUMENTS - The Future of Sound<<<<<<-
>>   >  >  >
>>   >  >  >  Registergericht: Amtsgericht Charlottenburg
>>   >  >  >  Registernummer: HRB 72458
>>   >  >  >  UST.-ID.-Nr. DE 20 374 7747
>>   >  >  >
>>   >  >  >  Geschäftsführung: Daniel Haver (CEO), Mate Galic
>>   >  >  >
>>   >  >  >
>>   >  >  >  ------------------------------------
>>   >  >  >
>>   >  >  >  Yahoo! Groups Links
>>   >  >  >
>>   >  >  >
>>   >  >  >
>>   >  >  >
>>   >  >
>>   >  >
>>   >
>>   >  --
>>   >  Dr. Norbert Nemec
>>   >  Software Development
>>   >
>>   >  Tel +49-30-611035-1882
>>   >  [hidden email]
>> <mailto:norbert.nemec%40native-instruments.de>
>>   >
>>   >  KOMPLETE 8 ULTIMATE - the premium NI producer collection
>>   >  =>  http://www.native-instruments.com/komplete8
>>   >
>>   >  TRAKTOR KONTROL S2 - the professional 2.1 DJ system
>>   >  =>  http://www.native-instruments.com/s2
>>   >
>>   >  ->>>>>>  NATIVE INSTRUMENTS - The Future of Sound<<<<<<-
>>   >
>>   >  Registergericht: Amtsgericht Charlottenburg
>>   >  Registernummer: HRB 72458
>>   >  UST.-ID.-Nr. DE 20 374 7747
>>   >
>>   >  Geschäftsführung: Daniel Haver (CEO), Mate Galic
>>   >
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

Norbert Nemec
Am 19.10.11 14:57, schrieb Thomas Singer (syntevo):

>  > Why isn't the diff editable right in
>  > the diff view at the bottom of the review window? Typically, this is the
>  > place where I view the changes. When I find an issue I need to edit, I
>  > should be able to do it right there rather than having to open the
>  > "Changes" window and find the same spot in the file again to make the
> edit.
>
> The Changes view will be updated automatically when the user selects a
> different file or when the file system refreshs. If we would make it
> editable, then the question would be what to do if the user changes
> selection? Should selection changes be prevented?

Intuitively I would expect a standard dialog asking about unsaved
changes (save,discard,cancel), where cancel should prevent the selection
change.

--
Dr. Norbert Nemec
Software Development

Tel +49-30-611035-1882
[hidden email]

KOMPLETE 8 ULTIMATE - the premium NI producer collection
=>  http://www.native-instruments.com/komplete8

TRAKTOR KONTROL S2 - the professional 2.1 DJ system
=>  http://www.native-instruments.com/s2

->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-

Registergericht: Amtsgericht Charlottenburg
Registernummer: HRB 72458
UST.-ID.-Nr. DE 20 374 7747

Geschäftsführung: Daniel Haver (CEO), Mate Galic
Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

syntevo Support
I don't agree on this item. A selection change never should cause a
dialog to popup. This would be very bad user experience IMHO.

--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


On 19.10.2011 15:14, Norbert Nemec wrote:

> Am 19.10.11 14:57, schrieb Thomas Singer (syntevo):
>>   >  Why isn't the diff editable right in
>>   >  the diff view at the bottom of the review window? Typically, this is the
>>   >  place where I view the changes. When I find an issue I need to edit, I
>>   >  should be able to do it right there rather than having to open the
>>   >  "Changes" window and find the same spot in the file again to make the
>> edit.
>>
>> The Changes view will be updated automatically when the user selects a
>> different file or when the file system refreshs. If we would make it
>> editable, then the question would be what to do if the user changes
>> selection? Should selection changes be prevented?
>
> Intuitively I would expect a standard dialog asking about unsaved
> changes (save,discard,cancel), where cancel should prevent the selection
> change.
>
Reply | Threaded
Open this post in threaded view
|

RE: Patchset review feature?

Nick Borrelli
Well, it would only popup if they make changes, yes?  In that case, the user would expect it.

 

I agree that the inability to edit while reviewing is a big problem.  I usually use third-party merge software, like Araxis, but I have found SmartGits to be really nice.  This is the one feature that bothers me though.

 

-Nick

 

From: [hidden email] [mailto:[hidden email]] On Behalf Of Thomas Singer (syntevo)
Sent: Wednesday, October 19, 2011 10:37 AM
To: [hidden email]
Subject: Re: [smartgit] Patchset review feature?

 

 

I don't agree on this item. A selection change never should cause a
dialog to popup. This would be very bad user experience IMHO.

--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com

On 19.10.2011 15:14, Norbert Nemec wrote:

> Am 19.10.11 14:57, schrieb Thomas Singer (syntevo):
>> > Why isn't the diff editable right in
>> > the diff view at the bottom of the review window? Typically, this is the
>> > place where I view the changes. When I find an issue I need to edit, I
>> > should be able to do it right there rather than having to open the
>> > "Changes" window and find the same spot in the file again to make the
>> edit.
>>
>> The Changes view will be updated automatically when the user selects a
>> different file or when the file system refreshs. If we would make it
>> editable, then the question would be what to do if the user changes
>> selection? Should selection changes be prevented?
>
> Intuitively I would expect a standard dialog asking about unsaved
> changes (save,discard,cancel), where cancel should prevent the selection
> change.
>





__________ Information from ESET NOD32 Antivirus, version of virus signature database 6557 (20111019) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com



[Non-text portions of this message have been removed]

Reply | Threaded
Open this post in threaded view
|

Re: Patchset review feature?

Norbert Nemec
The surprise could be minimized by giving clear visual feedback in the
moment of the first editing. Most editors display something like a small
star when there are unsaved changes. In this case, it should be more
obvious, like a large red bar in the status region lighting up on the
first edit. This should make cause and effect intuitively clear to the
user, so a popup for saving will not come as surprise. (Ideally, the
visual indicator could even give a hint for a key sequence for saving
the file.)



Am 19.10.11 19:22, schrieb Nick Borrelli:

> Well, it would only popup if they make changes, yes? In that case, the
> user would expect it.
>
> I agree that the inability to edit while reviewing is a big problem. I
> usually use third-party merge software, like Araxis, but I have found
> SmartGits to be really nice. This is the one feature that bothers me though.
>
> -Nick
>
> From: [hidden email] <mailto:smartgit%40yahoogroups.com>
> [mailto:[hidden email] <mailto:smartgit%40yahoogroups.com>] On
> Behalf Of Thomas Singer (syntevo)
> Sent: Wednesday, October 19, 2011 10:37 AM
> To: [hidden email] <mailto:smartgit%40yahoogroups.com>
> Subject: Re: [smartgit] Patchset review feature?
>
> I don't agree on this item. A selection change never should cause a
> dialog to popup. This would be very bad user experience IMHO.
>
> --
> Best regards,
> Thomas Singer
> =============
> syntevo GmbH
> http://www.syntevo.com
> http://blog.syntevo.com
>
> On 19.10.2011 15:14, Norbert Nemec wrote:
>  > Am 19.10.11 14:57, schrieb Thomas Singer (syntevo):
>  >> > Why isn't the diff editable right in
>  >> > the diff view at the bottom of the review window? Typically, this
> is the
>  >> > place where I view the changes. When I find an issue I need to edit, I
>  >> > should be able to do it right there rather than having to open the
>  >> > "Changes" window and find the same spot in the file again to make the
>  >> edit.
>  >>
>  >> The Changes view will be updated automatically when the user selects a
>  >> different file or when the file system refreshs. If we would make it
>  >> editable, then the question would be what to do if the user changes
>  >> selection? Should selection changes be prevented?
>  >
>  > Intuitively I would expect a standard dialog asking about unsaved
>  > changes (save,discard,cancel), where cancel should prevent the selection
>  > change.
>  >
>
> __________ Information from ESET NOD32 Antivirus, version of virus
> signature database 6557 (20111019) __________
>
> The message was checked by ESET NOD32 Antivirus.
>
> http://www.eset.com
>
> [Non-text portions of this message have been removed]
>
>

--
Dr. Norbert Nemec
Software Development

Tel +49-30-611035-1882
[hidden email]

KOMPLETE 8 ULTIMATE - the premium NI producer collection
=>  http://www.native-instruments.com/komplete8

TRAKTOR KONTROL S2 - the professional 2.1 DJ system
=>  http://www.native-instruments.com/s2

->>>>>> NATIVE INSTRUMENTS - The Future of Sound <<<<<<-

Registergericht: Amtsgericht Charlottenburg
Registernummer: HRB 72458
UST.-ID.-Nr. DE 20 374 7747

Geschäftsführung: Daniel Haver (CEO), Mate Galic