SmartGit review: Is it possible to filter comments by commit

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

SmartGit review: Is it possible to filter comments by commit

SmartGit mailing list
Hi All,

We are using the review option in SmartGit and really like this feature.
However we are using it without pull requests, and this makes the list of review comments in the repository grow longer and longer.

Is there a way to show only the review comments that belong to a selected commit ?

Thx,

Jurgen

 

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: SmartGit review: Is it possible to filter comments by commit

SmartGit mailing list
> Is there a way to show only the review comments that belong to a selected commit ?

The Details view will display all comments for the currently selected commit.

--
Best regards,
Marc Strapetz
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


11/24/2014 12:00 - [hidden email] [smartgit] wrote:

> Hi All,
>
> We are using the review option in SmartGit and really like this feature.
> However we are using it without pull requests, and this makes the list of review
> comments in the repository grow longer and longer.
>
> Is there a way to show only the review comments that belong to a selected commit ?
>
> Thx,
>
> Jurgen
>
>  
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: SmartGit review: Is it possible to filter comments by commit

SmartGit mailing list
Thanks for your answer.
This works for review comments placed directly on the commit.
However we would like this behavior also for the line comments...

When selecting a commit in the log, only show line comments from files in that commit in the comments window.
Currently all comments are showed there, also from files in other commits.

Thx
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: SmartGit review: Is it possible to filter comments by commit

SmartGit mailing list
> This works for review comments placed directly on the commit.
> However we would like this behavior also for the line comments...

I don't think that line comments without their context being displayed do make much sense. In the Files view you will already see those files for which line comments are present.

Why would you like to see all line comments at a glance?

--
Best regards,
Marc Strapetz
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


12/04/2014 10:20 - [hidden email] [smartgit] wrote:

> Thanks for your answer.
> This works for review comments placed directly on the commit.
> However we would like this behavior also for the line comments...
>
> When selecting a commit in the log, only show line comments from files in that
> commit in the comments window.
> Currently all comments are showed there, also from files in other commits.
>
> Thx
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: SmartGit review: Is it possible to filter comments by commit

SmartGit mailing list
>I don't think that line comments without their context being displayed do make much sense. In the Files view >you will already see those files for which line comments are present.

I agree that it does not make sense to show them in the details window.

>Why would you like to see all line comments at a glance?

Because the person who does the rework then can process the review comments one by one.
(Just double click on it)
However currenty the list in the comments window does not contain only the comments of the selected commit.

Regards
Jurgen
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: SmartGit review: Is it possible to filter comments by commit

SmartGit mailing list
> Because the person who does the rework then can process the review comments one by
> one.
> (Just double click on it)
> However currenty the list in the comments window does not contain only the
> comments of the selected commit.

OK. Added as RFE (SG-9063).

--
Best regards,
Marc Strapetz
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com


12/04/2014 11:20 - [hidden email] [smartgit] wrote:

> >I don't think that line comments without their context being displayed do make much sense. In the Files view >you will already see those files for which line comments are present.
>
> I agree that it does not make sense to show them in the details window.
>
> >Why would you like to see all line comments at a glance?
>
> Because the person who does the rework then can process the review comments one by
> one.
> (Just double click on it)
> However currenty the list in the comments window does not contain only the
> comments of the selected commit.
>
> Regards
> Jurgen
>
Loading...